> On Oct. 21, 2012, 4:16 p.m., Yuri Zelikov wrote: > > Hi > > I think the original issue was fixed by > > https://github.com/apache/wave/commit/2fbdcb9200b972d87d3667211ed0ce5db3326f53 > > and by > > https://github.com/apache/wave/commit/f34e33031801a1f2de4715a670a9c8c515c867d0 > > Or are there some additional issues? If so, can you please update WAVE-354 > > with more details?
Yes, those two patches hides the problem by not updating the digests at all while editing. This patch solves the issue for real by only updating the opened wave. The patch also adds the feature that the title and the snippet of the opened wave is updated in real time. - rocklund ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7683/#review12631 ----------------------------------------------------------- On Oct. 20, 2012, 4:49 p.m., rocklund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7683/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2012, 4:49 p.m.) > > > Review request for wave. > > > Description > ------- > > Fix for "SimpleSearch.DigestProxy should undate only the opened wave on > changes". Also updated so that the active digest update its title and snippet > in real time to make it feel more responsive and live. > > There might still be some code tweaks I should do and I still have two TODOs > in my code that I need to fix. > > Any feedback on the patch are welcome. Thanks! > > > This addresses bug WAVE-354. > https://issues.apache.org/jira/browse/WAVE-354 > > > Diffs > ----- > > src/org/waveprotocol/box/common/Snippets.java 099ce55 > src/org/waveprotocol/box/webclient/search/SearchPanelView.java e922fd4 > src/org/waveprotocol/box/webclient/search/SearchPanelWidget.java 4402b8e > src/org/waveprotocol/box/webclient/search/SearchPresenter.java b136c88 > src/org/waveprotocol/box/webclient/search/SimpleSearch.java 5b018d4 > src/org/waveprotocol/box/webclient/search/WaveBasedDigest.java 8d3cb92 > src/org/waveprotocol/wave/concurrencycontrol/wave/CcBasedWavelet.java > e87b1e0 > src/org/waveprotocol/wave/model/wave/Wavelet.java a463d45 > src/org/waveprotocol/wave/model/wave/opbased/OpBasedWavelet.java e99067c > > Diff: https://reviews.apache.org/r/7683/diff/ > > > Testing > ------- > > It would be good with some unit tests for the TitleHelper and the Snippet > classes but I don't think there currently are any good mock classes to use > for that. > > I tested manually on a locally running server. > > > Thanks, > > rocklund > >
