> On Nov. 6, 2012, 1:07 p.m., Vicente J. Ruiz Jurado wrote:
> > Tested and works correctly.
> > 
> > Maybe you can also update the README (or some other doc) with info about 
> > this script.

Sorry, I'm thinking that to have all the attachments in the same directory can 
be a bad idea in terms of scalability.

Anyway this patch it's necessary to have all previous attachments coherent with:
https://reviews.apache.org/r/7471/
but, what do you think?


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7832/#review13146
-----------------------------------------------------------


On Nov. 2, 2012, 12:56 p.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7832/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2012, 12:56 p.m.)
> 
> 
> Review request for wave, Vicente J. Ruiz Jurado, Ali Lown, and Andrew 
> Kaplanov.
> 
> 
> Description
> -------
> 
> Adds ant script to migrate attachments to the newer version. The script just 
> copies the attachments to the root of the attachments folder to comply with 
> the new mechanism.
> 
> 
> Diffs
> -----
> 
>   migrate-attachments.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7832/diff/
> 
> 
> Testing
> -------
> 
> Tested that the old attachments are displayed correctly in the up to date 
> version after running the migration script.
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>

Reply via email to