-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8916/#review15295
-----------------------------------------------------------
Another great patch! Thanks Andrew.
The patch looks good, just a few minor comments.
Another issue is that I got compilation error when trying to check the patch:
compile:
compile:
[echo] Compiling gwt-util
compile:
[echo] Compiling wave-api-0.3
compile:
[echo] Compiling box
[javac] Compiling 36 source files to
c:\cygwin\home\vega\mirrorspaces\wavesvn\build\src
[javac]
c:\cygwin\home\vega\mirrorspaces\wavesvn\src\org\waveprotocol\box\server\persistence\protos\ProtoAccountData
Serializer.java:152: cannot find symbol
[javac] symbol : method
setPasswordDigest(org.waveprotocol.box.server.authentication.PasswordDigest)
[javac] location: interface
org.waveprotocol.box.server.account.HumanAccountData
[javac]
account.setPasswordDigest(deserialize(data.getPasswordDigest()));
[javac] ^
[javac] 1 error
BUILD FAILED
c:\cygwin\home\vega\mirrorspaces\wavesvn\build.xml:239: The following error
occurred while executing this line:
c:\cygwin\home\vega\mirrorspaces\wavesvn\build-common.xml:28: The following
error occurred while executing this line:
c:\cygwin\home\vega\mirrorspaces\wavesvn\build-macros.xml:68: Compile failed;
see the compiler error output for details.
Total time: 25 seconds
./src/org/waveprotocol/box/server/util/URLParameters.java
<https://reviews.apache.org/r/8916/#comment32963>
URLParameters - > UrlParemeters
Also, please add private constructor to prevent instantiation
./src/org/waveprotocol/box/webclient/WebClientProd.gwt.xml
<https://reviews.apache.org/r/8916/#comment32964>
Can you please remove the trailing white space?
./src/org/waveprotocol/box/webclient/client/RemoteLocaleService.java
<https://reviews.apache.org/r/8916/#comment32965>
Can we remove this public no args constructor?
- Yuri Zelikov
On Jan. 10, 2013, 9:04 p.m., Andrew Kaplanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8916/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2013, 9:04 p.m.)
>
>
> Review request for wave.
>
>
> Description
> -------
>
> Realizes the possibility of switching and storing the user's language.
> Most phrases have been translated into several languages.
>
>
> Diffs
> -----
>
>
> ./proto_src/org/waveprotocol/box/server/persistence/protos/ProtoAccountStoreData.java
> 1430452
> ./src/org/waveprotocol/box/server/ServerMain.java 1430452
> ./src/org/waveprotocol/box/server/account/HumanAccountData.java 1430452
> ./src/org/waveprotocol/box/server/account/HumanAccountDataImpl.java 1430452
> ./src/org/waveprotocol/box/server/gxp/TopBar.gxp 1430452
> ./src/org/waveprotocol/box/server/gxp/WaveClientPage.gxp 1430452
>
> ./src/org/waveprotocol/box/server/persistence/protos/ProtoAccountDataSerializer.java
> 1430452
> ./src/org/waveprotocol/box/server/persistence/protos/account-store.proto
> 1430452
> ./src/org/waveprotocol/box/server/rpc/LocaleServlet.java PRE-CREATION
> ./src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 1430452
> ./src/org/waveprotocol/box/server/util/URLParameters.java PRE-CREATION
> ./src/org/waveprotocol/box/webclient/WebClientProd.gwt.xml 1430452
> ./src/org/waveprotocol/box/webclient/client/LocaleService.java PRE-CREATION
> ./src/org/waveprotocol/box/webclient/client/RemoteLocaleService.java
> PRE-CREATION
> ./src/org/waveprotocol/box/webclient/client/SavedStateIndicator.java
> 1430452
> ./src/org/waveprotocol/box/webclient/client/Session.java 1430452
> ./src/org/waveprotocol/box/webclient/client/WebClient.java 1430452
> ./src/org/waveprotocol/box/webclient/client/i18n/SavedStateMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/SavedStateMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/SavedStateMessages_ru.properties
> PRE-CREATION
> ./src/org/waveprotocol/box/webclient/client/i18n/SessionMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/SessionMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/SessionMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/SessionMessages_ru.properties
> PRE-CREATION
> ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages_sl.properties
> PRE-CREATION
> ./src/org/waveprotocol/box/webclient/search/DigestDomImpl.java 1430452
> ./src/org/waveprotocol/box/webclient/search/SearchPresenter.java 1430452
> ./src/org/waveprotocol/box/webclient/search/SearchWidget.ui.xml 1430452
> ./src/org/waveprotocol/box/webclient/search/i18n/DigestDomMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/DigestDomMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/DigestDomMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/DigestDomMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages_sl.properties
> PRE-CREATION
> ./src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/widget/error/ErrorIndicatorWidget.ui.xml
> 1430452
> ./src/org/waveprotocol/box/webclient/widget/error/i18n/ErrorMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/widget/error/i18n/ErrorMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/widget/error/i18n/ErrorMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/widget/error/i18n/ErrorMessages_ru.properties
> PRE-CREATION
> ./src/org/waveprotocol/box/webclient/widget/loading/LoadingIndicator.ui.xml
> 1430452
>
> ./src/org/waveprotocol/box/webclient/widget/loading/i18n/LoadingMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/widget/loading/i18n/LoadingMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/widget/loading/i18n/LoadingMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/box/webclient/widget/loading/i18n/LoadingMessages_ru.properties
> PRE-CREATION
> ./src/org/waveprotocol/wave/client/StageThree.java 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/event/EventDispatcherPanel.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/event/EventHandlerRegistry.java
> 1430452
> ./src/org/waveprotocol/wave/client/wavepanel/event/WaveChangeHandler.java
> PRE-CREATION
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/ActionsImpl.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantController.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ActionMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ActionMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ActionMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ActionMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages_sl.properties
> PRE-CREATION
> ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/MenuController.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages_sl.properties
> PRE-CREATION
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java
> 1430452
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/ViewToolbar.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/AttachmentPopupWidget.ui.xml
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/i18n/AttachmentMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/i18n/AttachmentMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/i18n/AttachmentMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/i18n/AttachmentMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.ui.xml
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetCategoryMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetCategoryMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetCategoryMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetCategoryMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetSelectorMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetSelectorMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetSelectorMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetSelectorMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/LinkerMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/LinkerMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/LinkerMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/LinkerMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages_sl.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipLinkPopupWidget.ui.xml
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/ParticipantsViewBuilder.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/ReplyBoxViewBuilder.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/WavePanelResourceLoader.java
> 1430452
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipLinkMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipLinkMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipLinkMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipLinkMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages_sl.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages_sl.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages_sl.properties
> PRE-CREATION
> ./src/org/waveprotocol/wave/client/widget/profile/ProfilePopupWidget.java
> 1430452
> ./src/org/waveprotocol/wave/client/widget/profile/ProfilePopupWidget.ui.xml
> 1430452
>
> ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages.java
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages_en.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages_fr.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages_ru.properties
> PRE-CREATION
>
> ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages_sl.properties
> PRE-CREATION
>
> ./test/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipViewBuilderTest.java
> 1430452
>
> ./test/org/waveprotocol/wave/client/wavepanel/view/dom/full/ReplyBoxBuilderTest.java
> 1430452
>
> ./test/org/waveprotocol/wave/client/wavepanel/view/dom/full/RootThreadViewBuilderTest.java
> 1430452
>
> ./test/org/waveprotocol/wave/client/wavepanel/view/dom/full/UiBuilderTestHelper.java
> 1430452
> ./war/static/earth.png UNKNOWN
>
> Diff: https://reviews.apache.org/r/8916/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Kaplanov
>
>
