----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8630/#review15392 -----------------------------------------------------------
I see it commited but some suggestion, to do a "chmod +x get_third_party.sh". Furthermore, I'm not an ant expert but maybe it's more elegant to exec this script in the test target. - Vicente J. Ruiz Jurado On Dec. 18, 2012, 8:25 p.m., Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8630/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 8:25 p.m.) > > > Review request for wave, Michael MacFadden, Vicente J. Ruiz Jurado, and Ali > Lown. > > > Description > ------- > > Adds get_third_party script to download junit and emma dependencies. > It also updates the junit to version 4.10 since I couldn't find download for > the old 3.8.2 version. > > > Diffs > ----- > > .gitignore 151cca9 > README eba3b57 > get_third_party.sh PRE-CREATION > third_party/test/emma/emma.jar 52f80e5 > third_party/test/emma/emma_ant.jar ee5134b > third_party/test/junit/README.google f92d92b > third_party/test/junit/junit.jar c8f711d > third_party/test/junit/src.jar 28ea5fc > > Diff: https://reviews.apache.org/r/8630/diff/ > > > Testing > ------- > > Executed "ant test" > > > Thanks, > > Yuri Zelikov > >
