----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9521/#review16853 -----------------------------------------------------------
Ship it! LGTM. - Ali Lown On Feb. 20, 2013, 1:44 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9521/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2013, 1:44 p.m.) > > > Review request for wave, Yuri Zelikov, Ali Lown, and Andrew Kaplanov. > > > Description > ------- > > This is a small patch that sends the wave client locale to gadgets, so > internationalized gadgets can load the correct client language. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/gadget/renderer/GadgetRenderer.java > 6d67c9e > src/org/waveprotocol/wave/client/gadget/renderer/SessionLocale.java 6212b0e > > Diff: https://reviews.apache.org/r/9521/diff/ > > > Testing > ------- > > All tests passed. > Also, adding a gadget to a wave, you have to see a correct "lang=YOUR_LANG" > parameter in the gadget iframe similar to the "locale=YOUR_LANG" of the web > client. > > Note: For testing, this gadget > http://taskboardy.googlecode.com/svn/trunk/taskboardy2.xml should be > translated if you change the webclient to Spanish language. > > > Thanks, > > Vicente J. Ruiz Jurado > >
