Re: Review Request 16751: MongoDB store for deltas

[Pablo Ojanguren]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16751/
-----------------------------------------------------------

(Updated Jan. 13, 2014, 3:07 p.m.)


Review request for wave.


Changes
-------

Changes for diff review 1 comments from Andrew


Bugs: WAVE-399
    https://issues.apache.org/jira/browse/WAVE-399


Repository: wave


Description
-------

Implementation of a MongoDB store for deltas via DeltaAccess and DeltaStore 
interfaces. 
All methods call DB avoiding memory structures.
Data model design is: a collection for storing deltas, a document per delta:

{ "_id" : { "$oid" : "52ce91a044ae038d55248a85"} , 
  "waveid" : "local.net/w+-WphE1C2YjA" , 
  "waveletid" : "local.net!conv+root" , 
  "appliedatversion" : { "version" : 84 , "historyhash" : { "$binary" : 
"4j3ZlQ35ss5OJUudS+0aH/+On1M=" , "$type" : 0}} , "applied" : { "$binary" : 
"..." , "$type" : 0} ,ç
  "transformed" : { "author" : { "address" : "r...@local.net"} , 
                    "resultingversion" : { "version" : 85 , "historyhash" : { 
"$binary" : "DmwTp4QLsGXL5dm9yPs9Pd9dMOo=" , "$type" : 0}} , 
                    "applicationtimestamp" : 1389269408793 , 
                    "appliedatversion" : 84 , 
                    "ops" : 
                          [ { "type" : "WaveletBlipOperation" , 
                              "blipid" : "b+-WphE1C2YjC" , 
                              "blipop" : { "contentop" : { "bytes" : { 
"$binary" : "CgIoDwoDEgFoCgIoAQ==" , "$type" : 0}}}}
                          ]}}


Diffs (updated)
-----

  src/org/waveprotocol/box/server/persistence/PersistenceModule.java a430570 
  
src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaCollection.java 
PRE-CREATION 
  src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaStore.java 
PRE-CREATION 
  
src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaStoreUtil.java 
PRE-CREATION 
  src/org/waveprotocol/box/server/persistence/mongodb/MongoDbProvider.java 
6f5170f 
  third_party/runtime/mongo-driver/mongo-2.1.jar 0936004 
  third_party/runtime/mongo-driver/mongo-java-driver-2.11.2.jar PRE-CREATION 
  third_party/runtime/mongo-driver/mongo-java-driver-r2.1-0-src.zip 41f4a34 

Diff: https://reviews.apache.org/r/16751/diff/


Testing
-------

Functional test only: three users editing concurrently same and differents 
waves from differentes clients.


Thanks,

Pablo Ojanguren