GitHub user pablojan opened a pull request:
https://github.com/apache/incubator-wave/pull/23
Removing atmosphere, revert to plain websockets
Atmosphere has been use for last two years to provide a reliable transport
layer for the client-server communications. However, at this moment it seems
better to remove it because the library is not longer maintained and its
integration with wave's code base is quite complex. Another reason is the lack
of native clients of atmosphere for iOS and Android.
I think we can provide easily those features we liked in atmosphere:
- In real environments it is required to do keep alive pings (aka heart
beats) through websocket to avoid network issues.
- Long-polling alternative is becoming less necessary these days as long
as websocket is now widely adopted. Anyway, I think to implement long polling
is not so hard.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pablojan/incubator-wave revert-websockets
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-wave/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 6c6f7938f1317558fcd7a399a24c6613fa96973d
Author: Pablo Ojanguren <[email protected]>
Date: 2017-04-17T14:00:34Z
Removing atmosphere, revert to plain websockets
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---