https://bugzilla.gnome.org/show_bug.cgi?id=759161
Matthias Clasen <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #317371|none |reviewed
status| |
--- Comment #21 from Matthias Clasen <[email protected]> ---
Review of attachment 317371:
::: gdk/wayland/gdkscreen-wayland.c
@@ +1275,3 @@
+ GdkWaylandScreen *screen_wayland = GDK_WAYLAND_SCREEN (screen);
+
+ return g_list_copy (screen_wayland->orphan_dialogs);
I would prefer to return the list itself here, without a copy. This is not
public api, and we know the only caller, so seems quite safe. Alternatively
(and maybe preferrably) keep the entire orphan dialog business static in
gdkwindow-wayland.c - there's only one screen object anyway, and we avoid
adding these (internal) apis.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
wayland-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-bugs
