https://bugzilla.gnome.org/show_bug.cgi?id=766341

Matthias Clasen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328005|none                        |accepted-commit_now
             status|                            |

--- Comment #32 from Matthias Clasen <[email protected]> ---
Review of attachment 328005:

Stil looks good to me

::: gdk/wayland/gdkdisplay-wayland.c
@@ +1125,3 @@
   if (ret < 0)
+    g_critical (G_STRLOC ": creating shared memory file failed: %m (fallback:
%s)",
+                force_shm_open? "true" : "false");

Instead of the meaningless 'fallback', I might reword this as

"creating shared memory file (%s) failed: %m", force_shm_open ? "shm_open" :
"memfd_create"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
wayland-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

Reply via email to