https://bugzilla.gnome.org/show_bug.cgi?id=774065
Jonas Ådahl <jad...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #366086|none |reviewed
status| |
--- Comment #10 from Jonas Ådahl <jad...@gmail.com> ---
Review of attachment 366086:
Thanks a lot for this! Here is some review:
Have this been tested on both input grabbing and not input grabbing entry
completion? Do we have test cases for both kinds?
Another question is how this deals with entry completion windows being moved,
as move_to_rect() can't deal with moving visible windows right now. Do we have
test cases for that? Do we even support that?
Lastly, for the future, please attach patches generated from "git format-patch"
with commit message and author information.
::: gtk/gtkentrycompletion.c
@@ +609,3 @@
priv->popup_window = gtk_window_new (GTK_WINDOW_POPUP);
+ /* Using subsurface prevents gdk_window_move_to_rect from working */
+ /* gtk_window_set_use_subsurface (GTK_WINDOW (priv->popup_window), TRUE); */
We should just remove this, not comment it out.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
