https://bugzilla.gnome.org/show_bug.cgi?id=786693
Martin Blanchard <tch...@gmx.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #368982|needs-work |none
status| |
Attachment #368982|0 |1
is obsolete| |
--- Comment #9 from Martin Blanchard <tch...@gmx.com> ---
Created attachment 369118
--> https://bugzilla.gnome.org/attachment.cgi?id=369118&action=edit
'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland
Fourth version: Handle both 'gtk-fontconfig-timestamp' and 'gtk-modules'.
(In reply to Bastien Nocera from comment #8)
> It also looks easy enough to extend and add support for the 2 other
> GtkSettings if you're interested.
Hummm, isn't 'gtk-enable-animations' already implemented as a gsetting?
> ::: gdk/wayland/gdkscreen-wayland.c
> @@ +70,3 @@
> Why use a struct here, and not directly a timestamp? The struct will be
> initialised to 0 when it's instantiated.
I've kept the struct so that dbus settings are grouped, that make it clear that
they'll be handle together.
> @@ +116,3 @@
> You can replace both lines with g_clear_object();
Done.
> @@ +713,3 @@
> Why the guard here? Wouldn't you want to return the "0" instead of an error
> here?
You're right, the distinction between a somehow fake initial value and 0 is of
little interest here.
> @@ +872,3 @@
> You can replace this loop with g_variant_lookup_value()
> Don't forget to exit early if the timestamp wasn't found.
Done.
> @@ +914,3 @@
> Either you should not use an error at all (you don't do anything with it),
> or you should have a few cases and print errors if the error is something
> other than the call being cancelled, or org.gtk.Settings not existing.
Agreed, my bad.
> @@ +969,3 @@
> You'll also want to add a cancellable here, which you would cancel and
> destroy in the finalize function.
Done.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
