https://bugs.freedesktop.org/show_bug.cgi?id=103749
--- Comment #28 from Davide Depau <dav...@depau.eu> ---
(In reply to Peter Hutterer from comment #27)
> Comment on attachment 138226 [details] [review]
> 0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch
>
> Review of attachment 138226 [details] [review]:
> -----------------------------------------------------------------
>
> This should work, but it's inefficient. You're still pairing the tablet mode
> and the keyboard device, installing an event handler, etc. But then you just
> return early when the event comes in. The original patch from comment 15
> just skips the pairing, which means it should have the same effect. So it'd
> be useful to debug why the other patch didn't take effect in
> fallback_keyboard_pair_tablet_mode().
I'll try to check again tomorrow or in the next few days and come up with
something more efficient.
> ::: src/evdev-fallback.c
> @@ +1151,4 @@
> > swev = libinput_event_get_switch_event(event);
> > if (libinput_event_switch_get_switch(swev) !=
> > LIBINPUT_SWITCH_TABLET_MODE)
> > + return;
>
> detritus, please remove
>
> @@ +1155,3 @@
> >
> > + if (device->model_flags & EVDEV_MODEL_TABLET_MODE_NO_SUSPEND)
> > + return;
>
> please stick to the indentation rules the rest of libinput uses
IDE's fault ;)
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
