> You should execute the ioctl in fbdev_set_screen_info. fbdev_set_screen_info is used only when the fb device is reenabled. The colors map has to be initialized at the beginning in all cases. If we use this function we will call it in all cases and it's not required.
>I don't see the codepath which results in cmap.transp being not set in the test for it. Yes... I forgot => new patch >You don't initialize cmap.red so the test for it gives an undefined result. Yes... error => new patch >Don't define macros in the middle of code with a literal that's only used once. In fact that comes from the cmap.transp which are not always initialized. In some cases transparency is useless. But I will repair => new patch New patch 2013/6/7 John Kåre Alsaker <john.kare.alsa...@gmail.com> > You should execute the ioctl in fbdev_set_screen_info. > > I don't see the codepath which results in cmap.transp being not set in the > test for it. > > You don't initialize cmap.red so the test for it gives an undefined result. > > Don't define macros in the middle of code with a literal that's only used > once. > > On Fri, Jun 7, 2013 at 12:18 PM, Marc Chalain <marc.chal...@gmail.com>wrote: > >> this patch allow to use direct color and set the colors map with default >> value. >> >> >> _______________________________________________ >> wayland-devel mailing list >> wayland-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/wayland-devel >> >> >
weston-fbdev-directcolor.patch
Description: Binary data
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
