On Wed, Nov 13, 2013 at 3:41 PM, Bill Spitzak <spit...@gmail.com> wrote:
> Is this to force the commit so that the subsurface appears? It might be > better to have a direct way to get the commit to happen without redrawing > the main surface. > It's to make sure that the transient's position and size is set, and that its redraw handler is called and that the subsurface is placed accordingly. I don't think we care too much about toytoolkit efficiently, so I'm fine with queueing a full redraw. Feel free to fix it if you feel strongly about making toytoolkit performant. > In any case this looks a lot like you are hiding a bug that perhaps should > be investigated, especially if it is in weston or your compositor, rather > than in the toytoolkit. > It is not a bug in the compositor. It's a bug in toytoolkit. Jasper St. Pierre wrote: > >> If a client adds a subsurface, we need to make sure it's allocated >> properly, so queue a resize and redraw on the parent window. >> --- >> clients/window.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/clients/window.c b/clients/window.c >> index 5a1c8ec..df56bd9 100644 >> --- a/clients/window.c >> +++ b/clients/window.c >> @@ -4462,6 +4462,9 @@ window_add_subsurface(struct window *window, void >> *data, >> assert(!"bad enum subsurface_mode"); >> } >> + window->resize_needed = 1; >> + window_schedule_redraw(window); >> + >> return widget; >> } >> >> > -- Jasper
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
