You guys should check the reason why the patch is there rather than throwing out random thoughts or blunt comments.
I did this patch mainly because weston/wayland has been using strtol/strtoul functions in number of places with buggy error checks, and duplicate code everywhere. Weston and wayland go together; so in bigger picture, its a very useful patch IMO.. I hardly find any patches with proper tests, but I did it so to make it more effective. But I guess in wayland/weston community, only maintainers are allowed to push patches others are strongly discouraged to do so. I guess its better to encourage people/community for giving helping hand. Anyways we will now only push patches (including multi-seat support) in Tizen weston/wayland rather than wasting time in upstreamn weston/wayland as it seems to be long bureaucratic process to overcome with virtually no success. BR imran On Tue, Oct 28, 2014 at 4:50 PM, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > > On 28 October 2014 11:21, Giulio Camuffo <giuliocamu...@gmail.com> wrote: > >> 2014-10-27 18:51 GMT+02:00 Jasper St. Pierre <jstpie...@mecheye.net>: >> > Can I also suggest that we don't make this public API? These are >> internal >> > helpers for libwayland, not designed for any consumers. We've been >> burned by >> > making too much internal helper API public before. >> >> +1 >> I don't think this belongs in the wayland API at all. That means >> duplicating them in weston, but they will hardly need modifications >> anyway. >> > > AOL. We're a window system, not a replacement libc. > > Cheers, > Dan >
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel