> Since d is not used subsequently in this function, why not combine the
> above two if statements into an and clause.  Then the patch is just a
> one-liner.
It needs to short-circuit the else block, so I can't put the conditions
together.

> It looks like this also gets called for ICH codes, where it looks like d
> isn't restricted to positive only values (afaict).  Will this cause any
> weird behaviors in that case?
I'll take a look at the way ICH needs to use it, good catch. :)
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to