On Wed, 22 Apr 2015 19:40:44 -0700 Bill Spitzak <spit...@gmail.com> wrote:
> This improvement to the protocol allows you to refer to the kind of enum you > are expecting. > It also introduces a distinction between enums that are bitfields, ie > that can be OR'ed together. > --- > protocol/wayland.dtd | 2 ++ > protocol/wayland.xml | 32 ++++++++++++++++---------------- > 2 files changed, 18 insertions(+), 16 deletions(-) Hi, I like the enum="" additions. I believe wayland-scanner should be ignoring unknown attributes since its inception, so that should not pose a problem. All in all this patch series would be a very good improvement to the docs. However, I don't think we have a closure on the enum/bitfield attribute discussion yet: how they can be used, what they guarantee and require, and what to do when things change. I think we need to see that through before taking this or the 2/2 patch, because these attributes may affect other code generators than C. (TBF, I haven't been able to dig into that discussion again.) Let's keep these two patches still in the queue until the enum/bitfield attribute design is decided. Thanks, pq
pgpVy0USblDsh.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
