Le 20/10/2015 10:24, Bryce Harrington a écrit : > On Mon, Oct 19, 2015 at 03:47:19PM +0200, David FORT wrote: >> This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. >> The target case is when the server has just send a capability event about a >> disappearing object, and the client binds the corresponding object. We bind >> an >> inert object: an object does nothing when it is requested. If the client >> behave >> correctly, this object should be released when the capability event is >> received >> and treated (calling the corresponding release request). >> As a consequence, we can rely on seat->[keyboard|pointer|touch]_state to know >> if the seat has the corresponding object. > > This is a big patch but it looks like the vast bulk is merely adding in > pointer checks for keyboard, pointer, etc. everywhere and subsequent > retabbing. If you broke that refactoring step out as a preliminary > patch, it may make reviewing the pertinent changes (i.e. tracking and > checking state for the input devices rather than just testing the > reference count) a bit easier.
I'm not sure to understand, what should I do then ? > > Thanks for tending to the test code too in the refactor; it would be > grand to see a test case added to keyboard-test or devices-test to > exercise the case of handling inert input objects. > Such a test is already there in the existing tests. In get_device_after_destroy of devices-test.c, we already exercise inert objects. Best regards -- David FORT website: http://www.hardening-consulting.com/ _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
