On Fri, Dec 04, 2015 at 09:25:06AM +0200, Pekka Paalanen wrote: > On Thu, 3 Dec 2015 17:38:34 -0800 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > On Fri, Dec 04, 2015 at 08:09:17AM +0800, Jonas Ådahl wrote: > > > On Thu, Dec 03, 2015 at 03:26:16PM -0800, Bryce Harrington wrote: > > > > On Thu, Dec 03, 2015 at 04:33:47PM +0800, Jonas Ådahl wrote: > > > > > This copies the version 5 of the XML to a new version 6 version, while > > > > > at the same time the interface names are changed to use the unstable > > > > > naming convention. > > > > > > > > > > A whitespace cleanup was done as no git-blame:ability would be lost > > > > > anyway. > > > > > > > > Just a bikeshed but would love to see tabs just go away in the xml > > > > files. They make protocol patches end up weirdly indented oftentimes. > > > > Otherwise... > > > > > > I too prefer spaces instead of tabs in XML files, but it seems spaces > > > lost to tabs in what has become the overwhelming majority of indentation > > > style in these XML files. > > > > Was there an explicit reason to favor tabs? Mere tradition seems not > > terribly compelling given that we've forced a rename and migration to a > > new repo only just recently. I'd be happy to volunteer for their > > replacement. > > Is there ever any better rationale to choose between spaces and tabs > than tradition, i.e. what is being already used... > > Though I would say that tab width being 8 has strong backing by > traditions and conventions all over that I would not change that. > > I personally do not care whether we go for spaces-only or 8-wide tabs > like now with XML files, because the indentation increment is already > not tab-wide. I would like to see consistency at least within a file. > XML nests far too much to have any super-useful indentation anyway IMHO.
I'd prefer to have consistency between files as well; so I won't have to maintain a per XML file indentation rule in my editor. > > If you want to change the whitespace in all XML files, I won't object, > but I don't think it is useful either. We'll just have to remember to > use 'git blame -w' like Mike mentioned if you do it. Personally, I see more troubles than gains in changing, but I only insist to either change all or none. Jonas > > > Thanks, > pq _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel