On Wed, Feb 03, 2016 at 07:24:10PM -0800, Bill Spitzak wrote: > On Wed, Feb 3, 2016 at 1:05 PM, Jasper St. Pierre <jstpie...@mecheye.net> > wrote: > > > On Wed, Feb 3, 2016 at 1:00 PM, Bill Spitzak <spit...@gmail.com> wrote: > > > > > > > > > On Wed, Feb 3, 2016 at 11:36 AM, Jasper St. Pierre < > > jstpie...@mecheye.net> > > > wrote: > > >> > > >> set_parent was moved to xdg_toplevel. Perhaps that's a good idea, > > >> perhaps it's not. This does mean that a tooltip's parent can never > > >> change, and a popup's parent can never change. That can help for > > >> getting grab semantics right, though it might be an idea if we say > > >> that set_parent on a popup / tooltip simply emit error if a parent is > > >> already set. I'm -1 to that, though. > > > > > > > > > xdg_toplevel *must* support the ability to change the parent. > > > > Somehow I get the feeling you're not even reading the words I'm > > writing. xdg_toplevel still has a set_parent method, I said it was > > moved *to* xdg_toplevel. > > > > Sorry I am confused then as to what the text "This does mean that a > tooltip's parent can never change, and a popup's parent can never change". > I think I misread it as "if we use xdg_surface set_parent, you cannot > change the parent", thus implying that xdg_surface set_parent cannot change > it. I think what you actually meant was "the current scheme does not allow > you to change the parent, this proposal *does* allow the parent to change".
Just repeating what Jasper already wrote in this thread, about the changes in this series. xdg_surface doesn't have a set_parent any more. > > If there are problems with making the grabs work, I think it is ok if > attempting to change the parent is either an error or ignored for surfaces > with the popup role. Again, xdg_surface doesn't have a set_parent request any more and I don't think there should be such a request there. xdg_popup (and xdg_tooltip) doesn't allow changing the parent, nor did they ever. Only xdg_toplevel allows changing the parent. xdg_toplevel is what xdg_surface was before. This is how it worked before. This series doesn't introduce any changes what so ever regarding setting/changing parents and stacking order. The only thing changed is exactly where (what interface) the requests doing what was done before is. Jonas _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
