On Wed, 23 Mar 2016 23:43:28 +0100 jeka <fried...@gmail.com> wrote: > Hi Pekka, > > I'm working in the same team with Emre and Natsume-san > please find some comments below > > On 22.03.2016 15:48, Pekka Paalanen wrote: > > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > > > Hi, > > > > I have written these simple patches as a side-product, and I'm proposing to > > merge them upstream. They are mostly just adding sanity checks, except the > > last > > one that is a possible behavioral change. > > > > I'm not sure what the proper response in hmi-controller would be in patch 5, > > and there probably is no way to test it readily. Feel free to reject that > > one > > if it's a too lazy patch. > agree to all patches besides the patch: > [PATCH weston 5/5] ivi-shell: forward zero size to controller > will add some comments in reply to the patch itself
Hi jeka, could you give a Reviewed-by line that I can append to patches 1-4 then, please? We'd prefer a real name over a nick. I'll drop patch 5. Thanks, pq > > > > > > Thanks, > > pq > > > > Pekka Paalanen (5): > > ivi-shell: add shell surface labels > > ivi-shell: add input panel label func > > ivi-shell: add sanity check in ivi_shell_surface_configure > > ivi-shell: harden get_ivi_shell_surface() > > ivi-shell: forward zero size to controller > > > > ivi-shell/hmi-controller.c | 2 ++ > > ivi-shell/input-panel-ivi.c | 8 ++++++++ > > ivi-shell/ivi-shell.c | 31 +++++++++++++++++++++++++++---- > > 3 files changed, 37 insertions(+), 4 deletions(-) > > > _______________________________________________ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel
pgplClS96PHuW.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
