On Wed, 27 Apr 2016 23:56:41 +0200 Benoit Gschwind <gschw...@gnu-log.net> wrote:
> I hope I covered all remaining issues. > > v3: > - update Makefile.am > - fix memory corruption/leak of device variable > - move transform configuration in the weston side > > v2: > - add src/compositor-fbdev.h in the Makefile.am > - fix typo > > Benoit Gschwind (3): > fbdev-backend: refactor configuration API > fbdev-backend: store device name into backend struct > fbdev-backend: move output transform configuration > > Makefile.am | 5 +++- > src/compositor-fbdev.c | 79 > +++++++++++++++++++++++--------------------------- > src/compositor-fbdev.h | 51 ++++++++++++++++++++++++++++++++ > src/main.c | 41 ++++++++++++++++++++++++-- > 4 files changed, 130 insertions(+), 46 deletions(-) > create mode 100644 src/compositor-fbdev.h > Hi Benoit, patch 2 is going a bit backwards, as it is moving the device string from fbdev_output to fbdev_backend. The only thing we needed was to strdup() it so that the compositor can free the argument as soon as fbdev backend has been created. I propose to drop patch 2. Instead, I sent the patch "compositor-fbdev: make copy of the device string" which would be landed first, and then I would land patches 1 and 3 squashed as they look good enough. How's that? I only need a Reviewed-by on the patch I sent, and then I can just merge it all. I have everything ready here. Thanks, pq
pgpd5vGZKe1_O.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel