Hello Pekka, Thanks for reviewing the patchset.
On 2016/06/15 17:22, Pekka Paalanen wrote: > On Fri, 27 May 2016 18:52:28 +0900 > Tomohito Esaki <e...@igel.co.jp> wrote: > >> Multiplanar formats are supported by using drmModeAddFB2 and bypassing >> gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path >> is used and multiplanar formats are unsupported. >> >> Signed-off-by: Tomohito Esaki <e...@igel.co.jp> >> --- >> src/compositor-drm.c | 47 +++++++++++++++++++---------------------------- >> 1 file changed, 19 insertions(+), 28 deletions(-) > > > Otherwise this patch looks good. Would you like to fix and re-post both? > Yes, I will update both patches as you suggested and send 2nd version soon. > Some ideas for further development if you are interested: > > - Check that dmabuf_attributes::flags does not contain anything we > don't support in the direct scanout paths. > > - Handle dmabuf_attributes::modifier[] when possible, or reject if > non-zero. > I think that scanout will not be supported if dmabuf_attributes::flags contains any flag other than INTERLACED flag or dmabuf_attributes::modifier[] is non-zero. I can add those checks to the patch too. Best regards -- -------------------------- IGEL Co., Ltd. Tomohito Esaki e...@igel.co.jp _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel