Hi Peter, > On Jul 18, 2016, at 5:49 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > > > Return values are a bit messy, we randomly use bool and int. Functions > returning int sometimes return 0 or 1, sometimes 0 and -1, etc. This set > cleans up a bit, mostly by switching a bunch of functions to just be void > and the rest to actual bool true/false returns (with renames where needed > for obviousness)
Other than the trailing return in 2/6, looks good to me. I would explicitly add the includes for stdbool, but that's at your discretion. > No functional changes, should be an easy review for a rainy day. Or to procrastinate other work... With my comments above in mind, this is Reviewed-by: Yong Bakos <yba...@humanoriented.com> yong > Cheers, > Peter > _______________________________________________ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel