On Wed, Aug 31, 2016 at 11:17:09PM +0100, Emil Velikov wrote: > On 31 August 2016 at 19:10, Derek Foreman <der...@osg.samsung.com> wrote: > >>> +* Edit a local copy of the script to make $WLD point to the base > >>> directory > >> How about one honours the WLD that's already set since ... > > > > It's not already set - the script exports it. Oh, this seems to be the > > same variable name used in some of the build instructions at: > > https://wayland.freedesktop.org/building.html > > > > and in weston's releasing.txt. > > > > Is that the problem? > > > Definitely not a problem, esp. since I've completely misread the help > text. Hope I'm the only one... > In general I'm biased towards "the script should just work and if you > modify it that means there's something wrong" behaviour.
The other wl_* scripts in wayland-build-tools load from a config file. I'd recommend wl_uninstall follow suit to remain consistent with the other scripts in the toolset. I.e.: #!/bin/bash . $HOME/.config/wayland-build-tools/wl_defines.sh if [ ! -e $WLROOT ]; then exit 1 fi #... An example wl_defines.sh is included in the git tree for the user to (manually) copy to .config/wayland-build-tools. (As described in step #2 in the README). It should work fine unmodified, but the user can customize their $WLD in that file without needing to edit any of the actual scripts or set up their environment. Bryce _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel