On Sun, May 14, 2017 at 04:33:15PM +0200, Gabriel Laskar wrote: > As said in > https://lists.freedesktop.org/archives/wayland-devel/2017-May/034074.html, we > probably can assume that offsetof will be supported by the compiler. > > Also some bugs came by: > * hwdb_parser.py assumes that python3 lives in /usr/bin, this forbid the usage > of virtualenv (or a python not installed in /usr/bin) > * The test suite seems broken on recent versions of libcheck, there is a > report > here: https://github.com/libcheck/check/issues/18. > > I have seen another issue in the usage of container_of, maybe I am wrong but > here, container_of takes a variable instead of a type name. This causes all > the > usages in the following files to have a unused variable in order for > container_of to work: > * src/evdev-lid.c > * src/evdev-mt-touchpad.h > * src/evdev-tablet.h > * src/evdev.h > > This requires minimal changes, but a change in the semantics of the version of > container_of that is used to match more closely the one used in the linux > kernel. > > Would you care for a patch for that?
yeah, that would work for me. These two are pushed, thanks. 695facc1..cef2a095 master -> master Cheers, Peter > > Gabriel Laskar (2): > util: use offsetof in container_of > udev/hwdb_parser.py: use python3 from env instead of /usr/bin > > src/libinput-util.h | 5 +++-- > udev/parse_hwdb.py | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > -- > 2.12.2 > > _______________________________________________ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel > _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel