Hi, I did not delete all block. Because block is reading and setting ivi-module from weston config. HMI-controller supports to be load as weston module in 3th patch. Therefore, ivi-shell would not work if I remove all block in the first patch.
I could remove the entire if statement in 3th patch though. Thank you for pushing. Best regards Emre Ucan Engineering Software Base (ADITG/ESB) Tel. +49 5121 49 6937 > -----Original Message----- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Mittwoch, 7. Februar 2018 10:57 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston v2 6/6] ivi-shell: remove ivi_shell_setting > > On Thu, 25 Jan 2018 14:37:38 +0100 > Emre Ucan <eu...@de.adit-jv.com> wrote: > > > it has only developermode option parameter. > > The parameter is only used in init_ivi_shell. > > Therefore, we can basically remove the struct, > > and check the option locally in the function. > > > > Signed-off-by: Emre Ucan <eu...@de.adit-jv.com> > > Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > --- > > ivi-shell/ivi-shell.c | 42 ++++++++++++------------------------------ > > 1 file changed, 12 insertions(+), 30 deletions(-) > > Hi, > > all six patches pushed: > b809d79d..f85bf152 master -> master > > I decided to overlook the temporary strange if-statement leftover. > > > Thanks, > pq _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
