On 15 March 2018 at 13:58, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Mon, 12 Mar 2018 16:41:46 +0100 > Guido Günther <a...@sigxcpu.org> wrote: > >> Since freedreno and etnaviv can live in parallel allow to build in >> different DRM backends. >> --- >> Makefile.am | 6 ++- >> clients/simple-dmabuf-drm.c | 122 >> +++++++++++++++++++++++++++++++++++--------- >> configure.ac | 29 +++++++---- >> 3 files changed, 121 insertions(+), 36 deletions(-) > > Hi, > > this seems mostly fine, but there are some issues noted below. It would > be appropriate to split this into two patches: "allow intel and > freedreno to be built together" and "add etnaviv support". > Just throwing it out there - one might be able to utilise the gbm_bo_{un,}map API. Haven't looked at the weston code, yet ^^ was sufficient for the piglit tests + kmscube.
Less code, fewer vendor quirks ;-) HTH -Emil _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel