On 19 March 2018 at 13:39, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 19 March 2018 at 13:27, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 19 March 2018 at 13:20, Daniel Stone <dan...@fooishbar.org> wrote: >>> Me neither really, but it seemed best for consistency with the rest of >>> the file which used test rather than [. >> >> Sounds fine either way - but the "test ||" -> "if test" changes seems >> spurious. >> If they stand out so much, guess one could have pointed it out? > > Not so much spurious as just broken? The final line, as written, will > only exit if _both_ added and removed are non-empty. If one but not > the other is non-empty, then the test will exit success[0]. > Right s/||/&&/ should address that
> I tried to think of a rewrite which would work, but in the end decided > making it explicit was the least error-prone thing to do, since this > one managed to slip past review with no-one noticing. > Fair point. Thanks! Emil _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel