On Sat, 24 Mar 2018 10:16:12 +0000 "Ray, Ian (GE Healthcare)" <ian....@ge.com> wrote:
> > On 23 Mar 2018, at 19.16, Ray, Ian (GE Healthcare) <ian....@ge.com> wrote: > > > > > >> On 23 Mar 2018, at 15.12, Ray, Ian (GE Healthcare) <ian....@ge.com> wrote: > >> > >> > >>> On 16 Feb 2018, at 16.56, Pekka Paalanen <ppaala...@gmail.com> wrote: > >>> > >>> From: Pekka Paalanen <pekka.paala...@collabora.co.uk> > >>> > >>> Hi all, > >>> > >>> here is the v6 of the shared-CRTC clone mode series. Since v5, quite > >>> many patches have been extracted from this series, sent out and merged > >>> upstream. However, now the series is bigger than ever, because here I am > >>> posting the complete series, including the full DRM-backend migration > >>> and DRM shared-CRTC clone mode implementation, thanks to having the > >>> basic atomic modesetting landed upstream. > >>> > >>> The previous submission is here: > >>> https://lists.freedesktop.org/archives/wayland-devel/2017-December/036236.html > >>> > >>> Design discussion etc. (sequence diagrams!) can be found here: > >>> https://phabricator.freedesktop.org/T7727 > >>> https://phabricator.freedesktop.org/w/wayland/weston/atomic-output-config/ > >>> https://lists.freedesktop.org/archives/wayland-devel/2017-October/035604.html > >>> > >>> The series is available as a branch at: > >>> https://gitlab.collabora.com/pq/weston/commits/clonemode-6 > >>> > >>> Highlights since v5: > >>> - DRM-backend migration > >>> - shared-CRTC clone mode implemented in DRM backend > >>> - applied review comments from v5 > >>> - don't create a weston_output just to turn it off (DRM) > >>> - cms-colord will print a warning when used with clone mode > >>> - cms-colord vs. clone mode mentioned in weston-drm.man > >>> > >>> Unfortunately the testing results are not 100%, you can find my testing > >>> procedure below the diffstat. > >>> > >>> The patch series is structured as follows: > >>> > >>> - Patches 1-17 introduce most of the new head-based API, and build the > >>> scaffolding that allows migrating the frontends and the backends one > >>> by one. > >>> > >> > >> Patches 01-17 : Reviewed-by Ian Ray <ian....@ge.com> > >> > >> > >>> - Patches 18-24 migrate the frontends one by one. Patch 19 introduces > >>> the simple output configurator which is first used for all backends, > >>> including the DRM-backend. > >>> > >>> - Patches 25-30 clean up libweston after the frontend migration. > > > > Patches 18-30 : Reviewed-by Ian Ray <ian....@ge.com> > > > > > >>> > >>> - Patches 31-38 migrate all the backends to the head-based API. At this > >>> point the DRM-backend migration is basically a fake, though. > >>> > >>> - Patch 39 removes weston_output::head with the last bits of the > >>> scaffolding. > > Patches 31-39 : Reviewed-by Ian Ray <ian....@ge.com> > > (May I say that I am really enjoying the review so far. The commits > are well structured and the commit messages are highly informative.) Thank you very much for the reviews, Ian! I have addressed your nitpicks and added your R-bs to the first 39 patches you went through. These can be found in the branch: https://gitlab.collabora.com/pq/weston/commits/clonemode-7-part1 I should probably test that a bit more before pushing. Now I'd just need an Acked-by or two from our oldtimers to land that batch. After that there would be 34 patches left to review in this series. Thanks, pq > >>> > >>> - Patches 40-44 enhances libweston core to better support the > >>> DRM-backend's clone mode configuration and improve logging. > >>> > >>> - Patches 45-55 implement the head-based API for real in the > >>> DRM-backend, culminating in patch 55 which creates heads for all > >>> connectors. > >>> > >>> - Patch 56 removes unused_connectors array which has been replace with > >>> the head list. > >>> > >>> - Patches 57-70 finally implement everything needed for shared-CRTC > >>> clone mode in the DRM-backend. > >>> > >>> - Patches 71-73 add a new output configrator logic in the frontend to > >>> handle clone mode, supporting a new weston.ini key "same-as". > >>> > >>> > >>> Do you think we should call the weston.ini key "clone-of" instead, to > >>> leave "same-as" reserved for clone mode where only the desktop area is > >>> the same but the monitors would have different video modes, scaling, > >>> etc.? > >>> > >>> There are several imaginable uses for "same-as" variants: > >>> - get me shared-CRTC clone mode or fail > >>> - get me clone mode, preferring shared-CRTC but automatic fallback to > >>> independent CRTCs > >>> - get me clone mode, but I want one monitor with HiDPI and one with > >>> LoDPI
pgpVSnPOFQaPY.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel