On 2018-05-30 02:48 PM, Pekka Paalanen wrote: > On Wed, 30 May 2018 18:33:40 +0800 > zou lan <nancy.lan....@gmail.com> wrote: > >> Hi pekka >> >> I'm not familiar with kernel. I know part of drm driver is implement by >> ourself. I check the vblank callback function, it sends pageflip event >> first if there is a frame complete, update vblank timestamp later. >> >> I don't know why the owner write code like this. but if I swap the code >> order, the fps decrease a lot. > > Hi Nancy, > > I do not know your hardware, so I cannot say why fps decreases, but the > order of sending event first and updating the timestamp later does > sound wrong to me.
Yes, drm_handle_vblank must be called before drm_crtc_send_vblank_event, otherwise it's not surprising that the timestamp in the event is wrong. :) -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
