Hi Pekka, On Fri, 6 Jul 2018 at 13:48, Pekka Paalanen <ppaala...@gmail.com> wrote: > > On Thu, 5 Jul 2018 18:16:34 +0100 > Daniel Stone <dani...@collabora.com> wrote: > > + /* Check the view spans exactly the output size, calculated in the > > + * logical co-ordinate space. */ > > + extents = pixman_region32_extents(&ev->transform.boundingbox); > > + if (extents->x1 != output->base.x || > > + extents->y1 != output->base.y || > > + extents->x2 != output->base.x + output->base.width || > > + extents->y2 != output->base.y + output->base.height) > > return NULL; > > Isn't this check a sub-set of the dest and src rectangles check below? > Is this needed for something? Just an early exit?
Yep, it allows us to skip trying to import a FB or set up plane state if we know the view can never be compatible. As you say, the below check is far more comprehensive, but this is enough to skip obviously pointless work. Cheers, Daniel _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
