> -----Original Message-----
> From: Alex Hung <alex.h...@amd.com>
> Sent: Friday, July 11, 2025 9:59 PM
> To: Simon Ser <cont...@emersion.fr>; Shankar, Uma
> <uma.shan...@intel.com>
> Cc: dri-de...@lists.freedesktop.org; amd-...@lists.freedesktop.org; wayland-
> de...@lists.freedesktop.org; harry.wentl...@amd.com; leo....@amd.com;
> ville.syrj...@linux.intel.com; pekka.paala...@collabora.com;
> m...@igalia.com; jad...@redhat.com; sebastian.w...@redhat.com;
> shashank.sha...@amd.com; ago...@nvidia.com; jos...@froggi.es;
> mdaen...@redhat.com; aleix...@kde.org; xaver.h...@gmail.com;
> victo...@system76.com; dan...@ffwll.ch; quic_nas...@quicinc.com;
> quic_cbr...@quicinc.com; quic_abhin...@quicinc.com; mar...@marcan.st;
> liviu.du...@arm.com; sashamcint...@google.com; Borah, Chaitanya
> Kumar <chaitanya.kumar.bo...@intel.com>; louis.chau...@bootlin.com;
> arthurgri...@riseup.net
> Subject: Re: [PATCH V10 33/46] drm: Add Enhanced LUT precision structure
>
>
>
> On 7/8/25 11:10, Simon Ser wrote:
> > On Tuesday, June 17th, 2025 at 06:26, Alex Hung <alex.h...@amd.com>
> wrote:
> >
> >> diff --git a/include/uapi/drm/drm_mode.h
> >> b/include/uapi/drm/drm_mode.h index 651bdf48b766..21bd96f437e0
> 100644
> >> --- a/include/uapi/drm/drm_mode.h
> >> +++ b/include/uapi/drm/drm_mode.h
> >> @@ -872,6 +872,16 @@ struct drm_color_lut {
> >> __u16 reserved;
> >> };
> >>
> >> +struct drm_color_lut_32 {
> >
> > Subjective nit: I would personally prefer "lut32" over "lut_32", but
> > that's very deep into bike-shedding territory. Feel free to ignore.
>
> I think it's a good idea.
>
> I got this from Uma's patchset. I will sync up with him to avoid future
> conflicts.
>
Just for the record, we took some inspiration from struct drm_color_ctm_3x4 for
this.
That said, I don’t mind the bike-shedding — naming things is half the fun
anyway. Happy to go with lut32 if that looks better!
@Uma feel free to disagree.
Regards
Chaitanya
> >
> >> + /*
> >> + * Similar to drm_color_lut but for high precision LUTs
> >> + */
> >
> > Instead of this code comment, would be nicer to have a proper doc
> comment.
> > In doc comments, "struct XXX" is enough to create a link. (struct
> > drm_color_lut doesn't have a doc comment, but has been introduced ages
> > ago.)
> >
> > "high precision" is a bit subjective, proibably "32-bit precision"
> > would be better.
> >
> >> + __u32 red;
> >> + __u32 green;
> >> + __u32 blue;
> >> + __u32 reserved;
> >> +};
> >> +
> >> /**
> >> * enum drm_colorop_type - Type of color operation
> >> *
> >> @@ -879,6 +889,7 @@ struct drm_color_lut {
> >> * and defines a different set of properties. This enum defines all types
> and
> >> * gives a high-level description.
> >> */
> >> +
> >
> > Nit: probably this extra newline should get dropped?
> >
> >> enum drm_colorop_type {
> >> /**
> >> * @DRM_COLOROP_1D_CURVE:
> >> --
> >> 2.43.0
