Fix looks like it's working- thanks. Glad I was able to stumble upon this issue. (moment.js author Tim Wood confims that calendar.js's .setFullYear was culprit )
On Monday, December 24, 2012 12:10:11 AM UTC-5, Massimo Di Pierro wrote: > > I believe the problem is now fixed. Please check it. > > yet the problem you reported is very serious and worse. In fact looks like > calendar.js included in web2py redefines Date.prototype.setFullYear and > this may results in wrong results when setting dates with or without using > moment.js. > > This was fixed only in trunk. If you experienced problems with dates, > upgrade calendar.js. > > Massimo > > On Sunday, 23 December 2012 15:57:27 UTC-6, Yarin wrote: >> >> 10 4 - Submitted issue to moment.js: >> https://github.com/timrwood/moment/issues/556 >> >> On Sunday, December 23, 2012 4:05:38 PM UTC-5, Massimo Di Pierro wrote: >>> >>> Looks like both do >>> >>> function something(){}; >>> >>> instead of >>> >>> var something=function(){} >>> >>> and therefore they both put and share functions in the global namespace. >>> >>> On Sunday, 23 December 2012 00:26:15 UTC-6, Yarin wrote: >>>> >>>> Not errors, just incorrect results- fails to parse dates, and returns >>>> isValid() false when testing valid date strings- see my bug report for a >>>> reproducable example- >>>> >>>> On Sat, Dec 22, 2012 at 10:27 PM, Massimo Di Pierro < >>>> massimo....@gmail.com> wrote: >>>> >>>>> Do you get any error in the chrome console? >>>>> >>>>> >>>>> On Saturday, 22 December 2012 20:41:43 UTC-6, Yarin wrote: >>>>>> >>>>>> We've found that the popular date library moment.js fails on date >>>>>> parsing when used alongside the calendar.js file included by default >>>>>> with >>>>>> web2py projects. >>>>>> >>>>>> I've submitted a bug report: >>>>>> http://code.google.com/p/**web2py/issues/detail?id=1243<http://code.google.com/p/web2py/issues/detail?id=1243> >>>>>> >>>>>> We removed calendar.js from our projects, but I'm unclear as to what >>>>>> it's there for? Where is it used, and why is it included by default? Is >>>>>> there a reason web2py doesn't use jquery's datepicker instead? >>>>>> >>>>>> >>>>>> -- >>>>> >>>>> >>>>> >>>>> >>>> >>>> --
