Thanks Jonathan. Fixed and uploading to trunk now.

On Sep 5, 4:16 pm, Jonathan Lundell <jlund...@pobox.com> wrote:
> On Sep 5, 2009, at 2:12 PM, mdipierro wrote:
>
>
>
> > yes it should. uploading to trunk now. Please check it.
>
> You said:
>
>          return self.stream(stream, chunk_size = chunk_size,  
> response=self)
>
> it should be:
>
>          return self.stream(stream, chunk_size = chunk_size,  
> request=request)
>
> Also, there's one more set of literal errnos in streamer.py.
>
>
>
> > On Sep 5, 4:08 pm, Jonathan Lundell <jlund...@pobox.com> wrote:
> >> On Sep 5, 2009, at 2:06 PM, Jonathan Lundell wrote:
>
> >>> On Sep 5, 2009, at 2:04 PM, Jonathan Lundell wrote:
>
> >>>> On Sep 5, 2009, at 1:56 PM, mdipierro wrote:
>
> >>>>> Is it ever called with request=None?
>
> >>>> Apparently; Jose was getting a crash to that effect. It's the
> >>>> declared
> >>>> default.
>
> >>> Response.download():
>
> >>>         return self.stream(stream, chunk_size = chunk_size)
>
> >> Perhaps Response.download() should be passing request to stream() ?
>
> >>      def download(self, request, db, chunk_size =  
> >> DEFAULT_CHUNK_SIZE):
> >>          ...
> >>          return self.stream(stream, chunk_size = chunk_size)
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"web2py-users" group.
To post to this group, send email to web2py@googlegroups.com
To unsubscribe from this group, send email to 
web2py+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/web2py?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to