Title: [86948] trunk/Source/WebCore
Revision
86948
Author
commit-qu...@webkit.org
Date
2011-05-20 06:49:54 -0700 (Fri, 20 May 2011)

Log Message

2011-05-20  Tonis Tiigi  <tonisti...@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: console.log(XMLDocument) should be case preserving
        https://bugs.webkit.org/show_bug.cgi?id=60765

        Changes the XML document checking from base documents MIME type
        to xmlVersion parameter.

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (86947 => 86948)


--- trunk/Source/WebCore/ChangeLog	2011-05-20 13:46:03 UTC (rev 86947)
+++ trunk/Source/WebCore/ChangeLog	2011-05-20 13:49:54 UTC (rev 86948)
@@ -1,3 +1,20 @@
+2011-05-20  Tonis Tiigi  <tonisti...@gmail.com>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: console.log(XMLDocument) should be case preserving
+        https://bugs.webkit.org/show_bug.cgi?id=60765
+
+        Changes the XML document checking from base documents MIME type
+        to xmlVersion parameter.
+
+        * inspector/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::buildObjectForNode):
+        * inspector/front-end/DOMAgent.js:
+        (WebInspector.DOMNode):
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
+
 2011-05-20  Mikhail Naganov  <mnaga...@chromium.org>
 
         Reviewed by Yury Semikhatsky.

Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (86947 => 86948)


--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2011-05-20 13:46:03 UTC (rev 86947)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp	2011-05-20 13:49:54 UTC (rev 86948)
@@ -1094,6 +1094,7 @@
         } else if (node->nodeType() == Node::DOCUMENT_NODE) {
             Document* document = static_cast<Document*>(node);
             value->setString("documentURL", documentURLString(document));
+            value->setString("xmlVersion", document->xmlVersion());
         }
     } else if (node->nodeType() == Node::DOCUMENT_TYPE_NODE) {
         DocumentType* docType = static_cast<DocumentType*>(node);

Modified: trunk/Source/WebCore/inspector/front-end/DOMAgent.js (86947 => 86948)


--- trunk/Source/WebCore/inspector/front-end/DOMAgent.js	2011-05-20 13:46:03 UTC (rev 86947)
+++ trunk/Source/WebCore/inspector/front-end/DOMAgent.js	2011-05-20 13:49:54 UTC (rev 86948)
@@ -75,6 +75,7 @@
         this.internalSubset = payload.internalSubset;
     } else if (this._nodeType === Node.DOCUMENT_NODE) {
         this.documentURL = payload.documentURL;
+        this.xmlVersion = payload.xmlVersion;
     } else if (this._nodeType === Node.ATTRIBUTE_NODE) {
         this.name = payload.name;
         this.value = payload.value;

Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (86947 => 86948)


--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js	2011-05-20 13:46:03 UTC (rev 86947)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js	2011-05-20 13:49:54 UTC (rev 86948)
@@ -56,7 +56,7 @@
 
         this._rootDOMNode = x;
 
-        this._isXMLMimeType = !!(WebInspector.mainResource && WebInspector.mainResource.mimeType && WebInspector.mainResource.mimeType.match(/x(?:ht)?ml/i));
+        this._isXMLMimeType = x && !!x.xmlVersion;
 
         this.update();
     },
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to