Title: [88100] trunk/Source/WebCore
- Revision
- 88100
- Author
- aba...@webkit.org
- Date
- 2011-06-04 02:22:28 -0700 (Sat, 04 Jun 2011)
Log Message
2011-06-04 Adam Barth <aba...@webkit.org>
Reviewed by Eric Seidel.
V8Proxy::disconnectFrame doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=62051
Dead code should die.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88099 => 88100)
--- trunk/Source/WebCore/ChangeLog 2011-06-04 09:05:38 UTC (rev 88099)
+++ trunk/Source/WebCore/ChangeLog 2011-06-04 09:22:28 UTC (rev 88100)
@@ -1,3 +1,17 @@
+2011-06-04 Adam Barth <aba...@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ V8Proxy::disconnectFrame doesn't do anything
+ https://bugs.webkit.org/show_bug.cgi?id=62051
+
+ Dead code should die.
+
+ * bindings/v8/ScriptController.cpp:
+ (WebCore::ScriptController::~ScriptController):
+ * bindings/v8/V8Proxy.cpp:
+ * bindings/v8/V8Proxy.h:
+
2011-06-04 Nico Weber <tha...@chromium.org>
Reviewed by James Robinson.
Modified: trunk/Source/WebCore/bindings/v8/ScriptController.cpp (88099 => 88100)
--- trunk/Source/WebCore/bindings/v8/ScriptController.cpp 2011-06-04 09:05:38 UTC (rev 88099)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.cpp 2011-06-04 09:22:28 UTC (rev 88100)
@@ -121,7 +121,6 @@
ScriptController::~ScriptController()
{
- m_proxy->disconnectFrame();
}
void ScriptController::clearScriptObjects()
Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.cpp (88099 => 88100)
--- trunk/Source/WebCore/bindings/v8/V8Proxy.cpp 2011-06-04 09:05:38 UTC (rev 88099)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.cpp 2011-06-04 09:22:28 UTC (rev 88100)
@@ -606,10 +606,6 @@
return retrieve(static_cast<Document*>(context)->frame());
}
-void V8Proxy::disconnectFrame()
-{
-}
-
void V8Proxy::didLeaveScriptContext()
{
Page* page = m_frame->page();
Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.h (88099 => 88100)
--- trunk/Source/WebCore/bindings/v8/V8Proxy.h 2011-06-04 09:05:38 UTC (rev 88099)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.h 2011-06-04 09:22:28 UTC (rev 88100)
@@ -149,10 +149,6 @@
bool timerCallback() const { return m_timerCallback; }
void setTimerCallback(bool value) { m_timerCallback = value; }
- // Disconnects the proxy from its owner frame,
- // and clears all timeouts on the DOM window.
- void disconnectFrame();
-
void finishedWithEvent(Event*) { }
// Evaluate _javascript_ in a new isolated world. The script gets its own
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
