Title: [88112] trunk/Source/WebKit/chromium
- Revision
- 88112
- Author
- tha...@chromium.org
- Date
- 2011-06-04 05:06:49 -0700 (Sat, 04 Jun 2011)
Log Message
2011-06-04 Nico Weber <tha...@chromium.org>
Reviewed by James Robinson.
[chromium] Make ResourceHandleInternal's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62073
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88111 => 88112)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 11:35:00 UTC (rev 88111)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 12:06:49 UTC (rev 88112)
@@ -2,6 +2,21 @@
Reviewed by James Robinson.
+ [chromium] Make ResourceHandleInternal's destructor virtual
+ https://bugs.webkit.org/show_bug.cgi?id=62073
+
+ This is _not_ to fix a real bug, just to make clang's
+ -Wdelete-non-virtual-dtor happy. As discussed at
+ http://codereview.chromium.org/7094005/, we prefer making leaf class
+ destructors virtual over making the leaf classes final.
+
+ * src/ResourceHandle.cpp:
+ (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
+
+2011-06-04 Nico Weber <tha...@chromium.org>
+
+ Reviewed by James Robinson.
+
[chromium] Make ChromePrintContext's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62076
Modified: trunk/Source/WebKit/chromium/src/ResourceHandle.cpp (88111 => 88112)
--- trunk/Source/WebKit/chromium/src/ResourceHandle.cpp 2011-06-04 11:35:00 UTC (rev 88111)
+++ trunk/Source/WebKit/chromium/src/ResourceHandle.cpp 2011-06-04 12:06:49 UTC (rev 88112)
@@ -62,6 +62,8 @@
{
}
+ virtual ~ResourceHandleInternal() { }
+
void start();
void cancel();
void setDefersLoading(bool);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
