Title: [88191] trunk/Source/WebKit/chromium
- Revision
- 88191
- Author
- tha...@chromium.org
- Date
- 2011-06-06 14:45:38 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Nico Weber <tha...@chromium.org>
Reviewed by James Robinson.
[chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
https://bugs.webkit.org/show_bug.cgi?id=62148
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
* src/WebURLRequest.cpp:
(WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
* src/WebURLResponse.cpp:
(WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88190 => 88191)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-06 21:35:56 UTC (rev 88190)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-06 21:45:38 UTC (rev 88191)
@@ -1,3 +1,20 @@
+2011-06-06 Nico Weber <tha...@chromium.org>
+
+ Reviewed by James Robinson.
+
+ [chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
+ https://bugs.webkit.org/show_bug.cgi?id=62148
+
+ This is _not_ to fix a real bug, just to make clang's
+ -Wdelete-non-virtual-dtor happy. As discussed at
+ http://codereview.chromium.org/7094005/, we prefer making leaf class
+ destructors virtual over making the leaf classes final.
+
+ * src/WebURLRequest.cpp:
+ (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
+ * src/WebURLResponse.cpp:
+ (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
+
2011-06-06 Shishir Agrawal <shis...@chromium.org>
Reviewed by Tony Gentilcore.
Modified: trunk/Source/WebKit/chromium/src/WebURLRequest.cpp (88190 => 88191)
--- trunk/Source/WebKit/chromium/src/WebURLRequest.cpp 2011-06-06 21:35:56 UTC (rev 88190)
+++ trunk/Source/WebKit/chromium/src/WebURLRequest.cpp 2011-06-06 21:45:38 UTC (rev 88191)
@@ -79,6 +79,8 @@
m_allowStoredCredentials = p->m_allowStoredCredentials;
}
+ virtual ~WebURLRequestPrivateImpl() { }
+
virtual void dispose() { delete this; }
ResourceRequest m_resourceRequestAllocation;
Modified: trunk/Source/WebKit/chromium/src/WebURLResponse.cpp (88190 => 88191)
--- trunk/Source/WebKit/chromium/src/WebURLResponse.cpp 2011-06-06 21:35:56 UTC (rev 88190)
+++ trunk/Source/WebKit/chromium/src/WebURLResponse.cpp 2011-06-06 21:45:38 UTC (rev 88191)
@@ -62,6 +62,8 @@
m_resourceResponse = &m_resourceResponseAllocation;
}
+ virtual ~WebURLResponsePrivateImpl() { }
+
virtual void dispose() { delete this; }
ResourceResponse m_resourceResponseAllocation;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
