Title: [88258] trunk/Source/WebCore
- Revision
- 88258
- Author
- [email protected]
- Date
- 2011-06-07 13:28:54 -0700 (Tue, 07 Jun 2011)
Log Message
2011-06-07 Alok Priyadarshi <[email protected]>
Reviewed by Stephen White.
[chromium] PlatformContextSkia leaks SkDeviceFactory
https://bugs.webkit.org/show_bug.cgi?id=62163
Valgrind tests should have caught this.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88257 => 88258)
--- trunk/Source/WebCore/ChangeLog 2011-06-07 20:23:18 UTC (rev 88257)
+++ trunk/Source/WebCore/ChangeLog 2011-06-07 20:28:54 UTC (rev 88258)
@@ -1,3 +1,15 @@
+2011-06-07 Alok Priyadarshi <[email protected]>
+
+ Reviewed by Stephen White.
+
+ [chromium] PlatformContextSkia leaks SkDeviceFactory
+ https://bugs.webkit.org/show_bug.cgi?id=62163
+
+ Valgrind tests should have caught this.
+
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
+
2011-06-07 Emil A Eklund <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp (88257 => 88258)
--- trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp 2011-06-07 20:23:18 UTC (rev 88257)
+++ trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp 2011-06-07 20:28:54 UTC (rev 88258)
@@ -750,7 +750,7 @@
SkDevice* device = factory->newDevice(m_canvas, SkBitmap::kARGB_8888_Config, drawingBuffer->size().width(), drawingBuffer->size().height(), false, false);
// FIXME: This should use a smart pointer.
m_canvas->setDevice(device)->unref();
- m_canvas->setDeviceFactory(factory);
+ m_canvas->setDeviceFactory(factory)->unref();
} else
m_accelerationMode = GPU;
} else {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
