Title: [88335] trunk/Source/WebCore
- Revision
- 88335
- Author
- commit-qu...@webkit.org
- Date
- 2011-06-08 03:33:12 -0700 (Wed, 08 Jun 2011)
Log Message
2011-06-08 Syed Idris Shah <syed.idris-s...@nokia.com>
Reviewed by Andreas Kling.
[Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop WebGL
https://bugs.webkit.org/show_bug.cgi?id=61945
For OpenGL ES we do not need these features.
These features are available via shaders in OpenGL ES. But for desktop WebGL using QtWebKit they should be enabled.
LayoutTests/fast/canvas/webgl/point-size.html
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88334 => 88335)
--- trunk/Source/WebCore/ChangeLog 2011-06-08 09:39:38 UTC (rev 88334)
+++ trunk/Source/WebCore/ChangeLog 2011-06-08 10:33:12 UTC (rev 88335)
@@ -1,3 +1,18 @@
+2011-06-08 Syed Idris Shah <syed.idris-s...@nokia.com>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop WebGL
+ https://bugs.webkit.org/show_bug.cgi?id=61945
+
+ For OpenGL ES we do not need these features.
+ These features are available via shaders in OpenGL ES. But for desktop WebGL using QtWebKit they should be enabled.
+
+ LayoutTests/fast/canvas/webgl/point-size.html
+
+ * platform/graphics/qt/GraphicsContext3DQt.cpp:
+ (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
+
2011-06-08 Gyuyoung Kim <gyuyoung....@samsung.com>
Unreviewed. Fix style error.
Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp (88334 => 88335)
--- trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp 2011-06-08 09:39:38 UTC (rev 88334)
+++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp 2011-06-08 10:33:12 UTC (rev 88335)
@@ -456,6 +456,11 @@
if (m_attrs.depth)
genRenderbuffers(/* count */ 1, &m_depthBuffer);
+#if !defined(QT_OPENGL_ES_2)
+ glEnable(GL_POINT_SPRITE);
+ glEnable(GL_VERTEX_PROGRAM_POINT_SIZE);
+#endif
+
// Bind canvas FBO and set initial clear color to black.
m_currentFbo = m_canvasFbo;
bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_canvasFbo);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes