Title: [88404] trunk/Source/_javascript_Core
Revision
88404
Author
e...@chromium.org
Date
2011-06-08 16:37:54 -0700 (Wed, 08 Jun 2011)

Log Message

2011-06-08  Evan Martin  <e...@chromium.org>

        Reviewed by Adam Barth.

        [chromium] use gyp 'settings' type for settings target
        https://bugs.webkit.org/show_bug.cgi?id=62323

        The 'settings' gyp target type is for targets that exist solely
        for their settings (no build rules).  The comment above this target
        says it's for this, but it incorrectly uses 'none'.

        * _javascript_Core.gyp/_javascript_Core.gyp:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (88403 => 88404)


--- trunk/Source/_javascript_Core/ChangeLog	2011-06-08 23:25:39 UTC (rev 88403)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-06-08 23:37:54 UTC (rev 88404)
@@ -1,3 +1,16 @@
+2011-06-08  Evan Martin  <e...@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [chromium] use gyp 'settings' type for settings target
+        https://bugs.webkit.org/show_bug.cgi?id=62323
+
+        The 'settings' gyp target type is for targets that exist solely
+        for their settings (no build rules).  The comment above this target
+        says it's for this, but it incorrectly uses 'none'.
+
+        * _javascript_Core.gyp/_javascript_Core.gyp:
+
 2011-06-08  Sailesh Agrawal  <s...@chromium.org>
 
         Reviewed by Mihai Parparita.

Modified: trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp (88403 => 88404)


--- trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2011-06-08 23:25:39 UTC (rev 88403)
+++ trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2011-06-08 23:37:54 UTC (rev 88404)
@@ -61,7 +61,7 @@
       # This target sets up defines and includes that are required by WTF and
       # its dependents.
       'target_name': 'wtf_config',
-      'type': 'none',
+      'type': 'settings',
       'msvs_guid': '2E2D3301-2EC4-4C0F-B889-87073B30F673',
       'direct_dependent_settings': {
         'defines': [
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to