Title: [88428] trunk/Source/WebCore
- Revision
- 88428
- Author
- commit-qu...@webkit.org
- Date
- 2011-06-08 23:38:08 -0700 (Wed, 08 Jun 2011)
Log Message
2011-06-08 James Robinson <jam...@chromium.org>
Reviewed by Darin Fisher.
REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349
r88260 fixed a font cache resource leak and lowered the inactive font cache threshold. The latter caused a
significant performance regression across many chromium page cyclers, for example
http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.
This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
logic.
* platform/graphics/FontCache.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88427 => 88428)
--- trunk/Source/WebCore/ChangeLog 2011-06-09 06:37:25 UTC (rev 88427)
+++ trunk/Source/WebCore/ChangeLog 2011-06-09 06:38:08 UTC (rev 88428)
@@ -1,3 +1,19 @@
+2011-06-08 James Robinson <jam...@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ REGRESSION(88260): 10-50% performance regression across many page cyclers
+ https://bugs.webkit.org/show_bug.cgi?id=62349
+
+ r88260 fixed a font cache resource leak and lowered the inactive font cache threshold. The latter caused a
+ significant performance regression across many chromium page cyclers, for example
+ http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.
+
+ This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
+ logic.
+
+ * platform/graphics/FontCache.cpp:
+
2011-06-08 Hayato Ito <hay...@chromium.org>
Reviewed by Dimitri Glazkov.
Modified: trunk/Source/WebCore/platform/graphics/FontCache.cpp (88427 => 88428)
--- trunk/Source/WebCore/platform/graphics/FontCache.cpp 2011-06-09 06:37:25 UTC (rev 88427)
+++ trunk/Source/WebCore/platform/graphics/FontCache.cpp 2011-06-09 06:38:08 UTC (rev 88428)
@@ -251,8 +251,8 @@
static FontDataCache* gFontDataCache = 0;
-const int cMaxInactiveFontData = 50; // Pretty Low Threshold
-const int cTargetInactiveFontData = 30;
+const int cMaxInactiveFontData = 120; // Pretty Low Threshold
+const int cTargetInactiveFontData = 100;
static ListHashSet<const SimpleFontData*>* gInactiveFontData = 0;
SimpleFontData* FontCache::getCachedFontData(const FontDescription& fontDescription, const AtomicString& family, bool checkingAlternateName, ShouldRetain shouldRetain)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
