Title: [88569] trunk
- Revision
- 88569
- Author
- commit-qu...@webkit.org
- Date
- 2011-06-10 14:42:29 -0700 (Fri, 10 Jun 2011)
Log Message
2011-06-10 Mark Pilgrim <pilg...@chromium.org>
Reviewed by Tony Chang.
IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398
* storage/indexeddb/database-name-undefined-expected.txt: Added.
* storage/indexeddb/database-name-undefined.html: Added.
2011-06-10 Mark Pilgrim <pilg...@chromium.org>
Reviewed by Tony Chang.
IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398
Test: storage/indexeddb/database-name-undefined.html
* storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (88568 => 88569)
--- trunk/LayoutTests/ChangeLog 2011-06-10 21:34:20 UTC (rev 88568)
+++ trunk/LayoutTests/ChangeLog 2011-06-10 21:42:29 UTC (rev 88569)
@@ -1,3 +1,13 @@
+2011-06-10 Mark Pilgrim <pilg...@chromium.org>
+
+ Reviewed by Tony Chang.
+
+ IndexedDB: indexedDB.open() name argument is required
+ https://bugs.webkit.org/show_bug.cgi?id=62398
+
+ * storage/indexeddb/database-name-undefined-expected.txt: Added.
+ * storage/indexeddb/database-name-undefined.html: Added.
+
2011-06-10 Emil A Eklund <e...@chromium.org>
Land Windows expectations for new test added in r88556.
Added: trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt (0 => 88569)
--- trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt 2011-06-10 21:42:29 UTC (rev 88569)
@@ -0,0 +1,20 @@
+Test IndexedDB undefined as record value
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;
+PASS indexedDB == null is false
+IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;
+PASS IDBDatabaseException == null is false
+IDBCursor = window.IDBCursor || window.webkitIDBCursor;
+PASS IDBCursor == null is false
+IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
+PASS IDBKeyRange == null is false
+Expecting exception from indexedDB.open();
+PASS Exception was thrown.
+PASS code is IDBDatabaseException.NON_TRANSIENT_ERR
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/storage/indexeddb/database-name-undefined.html (0 => 88569)
--- trunk/LayoutTests/storage/indexeddb/database-name-undefined.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/database-name-undefined.html 2011-06-10 21:42:29 UTC (rev 88569)
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<head>
+<link rel="stylesheet" href=""
+<script src=""
+<script src=""
+<script src=""
+</head>
+<body>
+<p id="description"></p>
+<div id="console"></div>
+<script>
+
+description("Test IndexedDB undefined as record value");
+if (window.layoutTestController)
+ layoutTestController.waitUntilDone();
+
+function test()
+{
+ indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;");
+ shouldBeFalse("indexedDB == null");
+ IDBDatabaseException = evalAndLog("IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;");
+ shouldBeFalse("IDBDatabaseException == null");
+ IDBCursor = evalAndLog("IDBCursor = window.IDBCursor || window.webkitIDBCursor;");
+ shouldBeFalse("IDBCursor == null");
+ IDBKeyRange = evalAndLog("IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;");
+ shouldBeFalse("IDBKeyRange == null");
+
+ evalAndExpectException("indexedDB.open();", "IDBDatabaseException.NON_TRANSIENT_ERR");
+ done();
+}
+
+var successfullyParsed = true;
+
+test();
+
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (88568 => 88569)
--- trunk/Source/WebCore/ChangeLog 2011-06-10 21:34:20 UTC (rev 88568)
+++ trunk/Source/WebCore/ChangeLog 2011-06-10 21:42:29 UTC (rev 88569)
@@ -1,3 +1,14 @@
+2011-06-10 Mark Pilgrim <pilg...@chromium.org>
+
+ Reviewed by Tony Chang.
+
+ IndexedDB: indexedDB.open() name argument is required
+ https://bugs.webkit.org/show_bug.cgi?id=62398
+
+ Test: storage/indexeddb/database-name-undefined.html
+
+ * storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
+
2011-06-10 Sam Weinig <s...@webkit.org>
Reviewed by Beth Dakin.
Modified: trunk/Source/WebCore/storage/IDBFactory.idl (88568 => 88569)
--- trunk/Source/WebCore/storage/IDBFactory.idl 2011-06-10 21:34:20 UTC (rev 88568)
+++ trunk/Source/WebCore/storage/IDBFactory.idl 2011-06-10 21:42:29 UTC (rev 88569)
@@ -28,7 +28,7 @@
interface [
Conditional=INDEXED_DATABASE
] IDBFactory {
- [CallWith=ScriptExecutionContext] IDBRequest open(in [ConvertNullToNullString] DOMString name)
+ [CallWith=ScriptExecutionContext] IDBRequest open(in [ConvertUndefinedOrNullToNullString] DOMString name)
raises (IDBDatabaseException);
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
