Title: [88847] trunk/Source/WebCore
- Revision
- 88847
- Author
- jer.no...@apple.com
- Date
- 2011-06-14 13:35:15 -0700 (Tue, 14 Jun 2011)
Log Message
2011-06-14 Jer Noble <jer.no...@apple.com>
Reviewed by Eric Carlson.
REGRESSION: Drawing video into canvas gets about one frame every 5 seconds (AVFoundation)
https://bugs.webkit.org/show_bug.cgi?id=62655
No new tests; we don't have any media-engine specific tests.
AVAssetImageGenerator will, by default, return the nearest keyframe. To get the generator to return
the image from the current time instead of the nearest keyframe, set the requested time tolerance to
zero (which defaults to infinity).
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88846 => 88847)
--- trunk/Source/WebCore/ChangeLog 2011-06-14 20:20:55 UTC (rev 88846)
+++ trunk/Source/WebCore/ChangeLog 2011-06-14 20:35:15 UTC (rev 88847)
@@ -1,3 +1,19 @@
+2011-06-14 Jer Noble <jer.no...@apple.com>
+
+ Reviewed by Eric Carlson.
+
+ REGRESSION: Drawing video into canvas gets about one frame every 5 seconds (AVFoundation)
+ https://bugs.webkit.org/show_bug.cgi?id=62655
+
+ No new tests; we don't have any media-engine specific tests.
+
+ AVAssetImageGenerator will, by default, return the nearest keyframe. To get the generator to return
+ the image from the current time instead of the nearest keyframe, set the requested time tolerance to
+ zero (which defaults to infinity).
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
+
2011-06-14 Eric Uhrhane <er...@chromium.org>
Reviewed by Darin Fisher.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm (88846 => 88847)
--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm 2011-06-14 20:20:55 UTC (rev 88846)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm 2011-06-14 20:35:15 UTC (rev 88847)
@@ -201,6 +201,8 @@
[m_imageGenerator.get() setApertureMode:AVAssetImageGeneratorApertureModeCleanAperture];
[m_imageGenerator.get() setAppliesPreferredTrackTransform:YES];
+ [m_imageGenerator.get() setRequestedTimeToleranceBefore:kCMTimeZero];
+ [m_imageGenerator.get() setRequestedTimeToleranceAfter:kCMTimeZero];
LOG(Media, "MediaPlayerPrivateAVFoundationObjC::createImageGenerator(%p) - returning %p", this, m_imageGenerator.get());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
