Title: [89358] trunk/Source/WebCore
- Revision
- 89358
- Author
- pva...@webkit.org
- Date
- 2011-06-21 08:58:33 -0700 (Tue, 21 Jun 2011)
Log Message
2011-06-21 Peter Varga <pva...@webkit.org>
Reviewed by Andreas Kling.
[Qt][V8] Enable marking objects with complex GC rules
https://bugs.webkit.org/show_bug.cgi?id=61291
No new tests needed.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89357 => 89358)
--- trunk/Source/WebCore/ChangeLog 2011-06-21 15:17:13 UTC (rev 89357)
+++ trunk/Source/WebCore/ChangeLog 2011-06-21 15:58:33 UTC (rev 89358)
@@ -1,3 +1,22 @@
+2011-06-21 Peter Varga <pva...@webkit.org>
+
+ Reviewed by Andreas Kling.
+
+ [Qt][V8] Enable marking objects with complex GC rules
+ https://bugs.webkit.org/show_bug.cgi?id=61291
+
+ No new tests needed.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/test/V8/V8TestInterface.cpp:
+ (WebCore::V8TestInterface::wrapSlow):
+ * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
+ (WebCore::V8TestMediaQueryListListener::wrapSlow):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::V8TestObj::wrapSlow):
+ * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+ (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
+
2011-06-20 Pavel Feldman <pfeld...@chromium.org>
Reviewed by Yury Semikhatsky.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (89357 => 89358)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-06-21 15:17:13 UTC (rev 89357)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-06-21 15:58:33 UTC (rev 89358)
@@ -2573,13 +2573,9 @@
push(@implContent, <<END);
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
-\#if !PLATFORM(QT)
-// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
-// https://bugs.webkit.org/show_bug.cgi?id=61291
if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
-\#endif
END
if (IsNodeSubType($dataNode)) {
push(@implContent, <<END);
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp (89357 => 89358)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp 2011-06-21 15:17:13 UTC (rev 89357)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp 2011-06-21 15:58:33 UTC (rev 89358)
@@ -103,13 +103,9 @@
impl->ref();
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
-#if !PLATFORM(QT)
-// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
-// https://bugs.webkit.org/show_bug.cgi?id=61291
if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
-#endif
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp (89357 => 89358)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp 2011-06-21 15:17:13 UTC (rev 89357)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp 2011-06-21 15:58:33 UTC (rev 89358)
@@ -110,13 +110,9 @@
impl->ref();
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
-#if !PLATFORM(QT)
-// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
-// https://bugs.webkit.org/show_bug.cgi?id=61291
if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
-#endif
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (89357 => 89358)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-06-21 15:17:13 UTC (rev 89357)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-06-21 15:58:33 UTC (rev 89358)
@@ -1397,13 +1397,9 @@
impl->ref();
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
-#if !PLATFORM(QT)
-// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
-// https://bugs.webkit.org/show_bug.cgi?id=61291
if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
-#endif
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp (89357 => 89358)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp 2011-06-21 15:17:13 UTC (rev 89357)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp 2011-06-21 15:58:33 UTC (rev 89358)
@@ -99,13 +99,9 @@
impl->ref();
SerializedScriptValue::deserializeAndSetProperty(wrapper, "value", static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly), impl->value());
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
-#if !PLATFORM(QT)
-// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
-// https://bugs.webkit.org/show_bug.cgi?id=61291
if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
-#endif
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes