Title: [89517] trunk/Source/WebCore
- Revision
- 89517
- Author
- joep...@webkit.org
- Date
- 2011-06-22 18:43:22 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Joseph Pecoraro <joep...@webkit.org>
Reviewed by Darin Adler.
Remove comment about pages with frames not being page-cachable
https://bugs.webkit.org/show_bug.cgi?id=63207
This comment was out of date. Caching pages with Frames in
the PageCache has worked since 2009:
<http://webkit.org/b/13631> Page Cache should support pages with frames
* history/PageCache.cpp:
(WebCore::PageCache::canCache):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89516 => 89517)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 01:36:42 UTC (rev 89516)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 01:43:22 UTC (rev 89517)
@@ -1,3 +1,17 @@
+2011-06-22 Joseph Pecoraro <joep...@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Remove comment about pages with frames not being page-cachable
+ https://bugs.webkit.org/show_bug.cgi?id=63207
+
+ This comment was out of date. Caching pages with Frames in
+ the PageCache has worked since 2009:
+ <http://webkit.org/b/13631> Page Cache should support pages with frames
+
+ * history/PageCache.cpp:
+ (WebCore::PageCache::canCache):
+
2011-06-22 Yael Aharon <yael.aha...@nokia.com>
Reviewed by Andreas Kling.
Modified: trunk/Source/WebCore/history/PageCache.cpp (89516 => 89517)
--- trunk/Source/WebCore/history/PageCache.cpp 2011-06-23 01:36:42 UTC (rev 89516)
+++ trunk/Source/WebCore/history/PageCache.cpp 2011-06-23 01:43:22 UTC (rev 89517)
@@ -299,8 +299,6 @@
// store the final page we end up on.
// No point writing to the cache on a reload or loadSame, since we will just write
// over it again when we leave that page.
- // FIXME: <rdar://problem/4886592> - We should work out the complexities of caching pages with frames as they
- // are the most interesting pages on the web, and often those that would benefit the most from caching!
FrameLoadType loadType = page->mainFrame()->loader()->loadType();
return canCachePageContainingThisFrame(page->mainFrame())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
