Title: [90123] trunk/Tools
- Revision
- 90123
- Author
- [email protected]
- Date
- 2011-06-30 08:30:52 -0700 (Thu, 30 Jun 2011)
Log Message
Use a colon to separate test names from failure info on TestFailures
This matches how the "Possibly Flaky Tests" list works, and is much prettier when the
failure info itself includes parentheses.
Fixes <http://webkit.org/b/63722> Crashing symbols on TestFailures page look ugly due to
double parentheses
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForFailedTest): Use a colon instead of surrounding the failure
info in parentheses.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (90122 => 90123)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-06-30 15:30:43 UTC (rev 90122)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-06-30 15:30:52 UTC (rev 90123)
@@ -248,10 +248,8 @@
_domForFailedTest: function(builder, buildName, testName, testResult) {
var result = document.createDocumentFragment();
- result.appendChild(document.createTextNode(testName));
- result.appendChild(document.createTextNode(' ('));
+ result.appendChild(document.createTextNode(testName + ': '));
result.appendChild(this._domForFailureDiagnosis(builder, buildName, testName, testResult));
- result.appendChild(document.createTextNode(')'));
return result;
},
Modified: trunk/Tools/ChangeLog (90122 => 90123)
--- trunk/Tools/ChangeLog 2011-06-30 15:30:43 UTC (rev 90122)
+++ trunk/Tools/ChangeLog 2011-06-30 15:30:52 UTC (rev 90123)
@@ -1,5 +1,21 @@
2011-06-30 Adam Roben <[email protected]>
+ Use a colon to separate test names from failure info on TestFailures
+
+ This matches how the "Possibly Flaky Tests" list works, and is much prettier when the
+ failure info itself includes parentheses.
+
+ Fixes <http://webkit.org/b/63722> Crashing symbols on TestFailures page look ugly due to
+ double parentheses
+
+ Reviewed by Darin Adler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+ (ViewController.prototype._domForFailedTest): Use a colon instead of surrounding the failure
+ info in parentheses.
+
+2011-06-30 Adam Roben <[email protected]>
+
Robustify PersistentCache against cached data that contains the string ': '
Fixes <http://webkit.org/b/63721> Exceptions thrown while loading TestFailures page due to
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
