Title: [90132] trunk/Websites/bugs.webkit.org
- Revision
- 90132
- Author
- [email protected]
- Date
- 2011-06-30 10:24:26 -0700 (Thu, 30 Jun 2011)
Log Message
2011-06-30 Adam Barth <[email protected]>
Reviewed by Eric Seidel.
[reviewtool] Expanding lines "below" does not remove purple context line
https://bugs.webkit.org/show_bug.cgi?id=63695
Honestly, this is the last bug in the review tool that bothers me.
* PrettyPatch/PrettyPatch.rb:
- Jump straight to version 42, because, well, you know.
* code-review.js:
- In addition to removing the context bar when we expand all, we
now remove it when we expand below (but not when we expand
above).
Modified Paths
Diff
Modified: trunk/Websites/bugs.webkit.org/ChangeLog (90131 => 90132)
--- trunk/Websites/bugs.webkit.org/ChangeLog 2011-06-30 17:04:46 UTC (rev 90131)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2011-06-30 17:24:26 UTC (rev 90132)
@@ -1,3 +1,19 @@
+2011-06-30 Adam Barth <[email protected]>
+
+ Reviewed by Eric Seidel.
+
+ [reviewtool] Expanding lines "below" does not remove purple context line
+ https://bugs.webkit.org/show_bug.cgi?id=63695
+
+ Honestly, this is the last bug in the review tool that bothers me.
+
+ * PrettyPatch/PrettyPatch.rb:
+ - Jump straight to version 42, because, well, you know.
+ * code-review.js:
+ - In addition to removing the context bar when we expand all, we
+ now remove it when we expand below (but not when we expand
+ above).
+
2011-06-21 Adam Barth <[email protected]>
Reviewed by Darin Adler.
Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (90131 => 90132)
--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2011-06-30 17:04:46 UTC (rev 90131)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2011-06-30 17:24:26 UTC (rev 90132)
@@ -461,7 +461,7 @@
}
</style>
<script src=""
-<script src=""
+<script src=""
EOF
def self.revisionOrDescription(string)
Modified: trunk/Websites/bugs.webkit.org/code-review.js (90131 => 90132)
--- trunk/Websites/bugs.webkit.org/code-review.js 2011-06-30 17:04:46 UTC (rev 90131)
+++ trunk/Websites/bugs.webkit.org/code-review.js 2011-06-30 17:24:26 UTC (rev 90132)
@@ -773,6 +773,10 @@
}
}
+ function removeContextBarBelow(expand_bar) {
+ $('.context', expand_bar.nextElementSibling).detach();
+ }
+
function expand(expand_bar, file_name, direction, amount) {
if (file_name in original_file_contents && !patched_file_contents[file_name]) {
// FIXME: In this case, try fetching the source file at the revision the patch was created at.
@@ -837,12 +841,12 @@
if (start_line_num == above_last_line_num && end_line_num == below_first_line_num) {
$('.ExpandLinkContainer', expand_bar).detach();
below_expansion.insertBefore(lines, below_expansion.firstChild);
- // Now that we're filling in all the lines, the context line following this expand bar is no longer needed.
- $('.context', expand_bar.nextElementSibling).detach();
+ removeContextBarBelow(expand_bar);
} else if (direction == ABOVE) {
above_expansion.appendChild(lines);
} else {
below_expansion.insertBefore(lines, below_expansion.firstChild);
+ removeContextBarBelow(expand_bar);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
