Title: [90195] trunk
- Revision
- 90195
- Author
- [email protected]
- Date
- 2011-06-30 19:52:59 -0700 (Thu, 30 Jun 2011)
Log Message
2011-06-30 Kent Tamura <[email protected]>
Reviewed by Darin Fisher.
[Chromium] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700
* platform/chromium/test_expectations.txt: Tests for <details> fail temporarily.
2011-06-30 Kent Tamura <[email protected]>
Reviewed by Darin Fisher.
[Chromium] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700
* public/WebLocalizedString.h: Add new key.
* src/LocalizedStrings.cpp: Call query() with the new key.
(WebCore::defaultDetailsSummaryText):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90194 => 90195)
--- trunk/LayoutTests/ChangeLog 2011-07-01 02:42:18 UTC (rev 90194)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 02:52:59 UTC (rev 90195)
@@ -1,3 +1,12 @@
+2011-06-30 Kent Tamura <[email protected]>
+
+ Reviewed by Darin Fisher.
+
+ [Chromium] Implement WebCore::defaultDetailsSummaryText()
+ https://bugs.webkit.org/show_bug.cgi?id=63700
+
+ * platform/chromium/test_expectations.txt: Tests for <details> fail temporarily.
+
2011-06-30 Zhenyao Mo <[email protected]>
Reviewed by Kenneth Russell.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90194 => 90195)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 02:42:18 UTC (rev 90194)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 02:52:59 UTC (rev 90195)
@@ -3788,6 +3788,16 @@
// Flaky since added by r86478
BUGCR82881 : http/tests/appcache/interrupted-update.html = PASS TEXT
+// Temporary failures because of "Details" localization.
+BUGWK63700 : fast/html/details-no-summary1.html = FAIL
+BUGWK63700 : fast/html/details-no-summary2.html = FAIL
+BUGWK63700 : fast/html/details-no-summary3.html = FAIL
+BUGWK63700 : fast/html/details-no-summary4.html = FAIL
+BUGWK63700 : fast/html/details-remove-summary-1-and-click.html = FAIL
+BUGWK63700 : fast/html/details-remove-summary-1.html = FAIL
+BUGWK63700 : fast/html/details-remove-summary-4-and-click.html = FAIL
+BUGWK63700 : fast/html/details-remove-summary-4.html = FAIL
+
// Flaky on Linux
BUGCR82891 LINUX : fast/speech/input-appearance-numberandspeech.html = TEXT IMAGE+TEXT PASS
BUGCR82891 LINUX : fast/speech/input-appearance-searchandspeech.html = FAIL PASS
Modified: trunk/Source/WebKit/chromium/ChangeLog (90194 => 90195)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 02:42:18 UTC (rev 90194)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 02:52:59 UTC (rev 90195)
@@ -1,3 +1,14 @@
+2011-06-30 Kent Tamura <[email protected]>
+
+ Reviewed by Darin Fisher.
+
+ [Chromium] Implement WebCore::defaultDetailsSummaryText()
+ https://bugs.webkit.org/show_bug.cgi?id=63700
+
+ * public/WebLocalizedString.h: Add new key.
+ * src/LocalizedStrings.cpp: Call query() with the new key.
+ (WebCore::defaultDetailsSummaryText):
+
2011-06-30 Andrew Scherkus <[email protected]>
Unreviewed.
Modified: trunk/Source/WebKit/chromium/public/WebLocalizedString.h (90194 => 90195)
--- trunk/Source/WebKit/chromium/public/WebLocalizedString.h 2011-07-01 02:42:18 UTC (rev 90194)
+++ trunk/Source/WebKit/chromium/public/WebLocalizedString.h 2011-07-01 02:52:59 UTC (rev 90195)
@@ -35,6 +35,7 @@
struct WebLocalizedString {
enum Name {
+ DetailsLabel,
SubmitButtonDefaultLabel,
InputElementAltText,
ResetButtonDefaultLabel,
Modified: trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp (90194 => 90195)
--- trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp 2011-07-01 02:42:18 UTC (rev 90194)
+++ trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp 2011-07-01 02:52:59 UTC (rev 90195)
@@ -94,8 +94,7 @@
String defaultDetailsSummaryText()
{
- notImplemented();
- return String("Details");
+ return query(WebLocalizedString::DetailsLabel);
}
String fileButtonNoFileSelectedLabel()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
